Feature/reintroduce flux limiter #772
Open
+73
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ofile columns flux_limit_lambda and flux_limit_R (ported from r9793)
Porting the flux-limiter prescription from r9793 to the latest MESA version
|
Let's make sure there are no floating point errors associated with this. I don't know if we need to save any star information in the photos, but let's see what happens to : all use dPrad_dm form of the T-gradient eqn. https://testhub.mesastar.org/feature%2Freintroduce_flux_limiter/commits/9f8a91c. I'll add a fpe check as well. |
pmocz
reviewed
Feb 12, 2025
| @@ -8226,6 +8234,7 @@ | |||
| ! :: | |||
|
|
|||
| use_dPrad_dm_form_of_T_gradient_eqn = .false. | |||
| use_flux_limiting_with_dPrad_dm_form = .true. | |||
There was a problem hiding this comment.
reminder: switch back to false before merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #771. where @JRGarza has reimplemented a flux limiter for use with the dPrad_dm form of the T-gradient equation.
Resolves #769
Related to #625